Skip to content

Add a nanokvm command for one-off actions - #64

Merged
chiconws merged 1 commit into
puddly:devfrom
antoniovazquezblanco:cli
Nov 16, 2026
Merged

chiconws merged 1 commit into
puddly:devfrom
antoniovazquezblanco:cli

Conversation

@antoniovazquezblanco

Copy link
Copy Markdown
Contributor

The command runs on the blocking client: info, status, power press, on and off, reset, images, mount and unmount. 'power on' and 'power off' do nothing when the power LED already shows that state, and otherwise wait for the LED. The password comes from NANOKVM_PASSWORD or a prompt, never from the command line.

@chiconws

Copy link
Copy Markdown
Collaborator

Thanks for this, and sorry it sat for two weeks. #63 is merged.

The CLI looks good. It still merges cleanly on dev and the tests pass. I ran info and status against a NanoKVM PCIe on application 2.5.4, and both work.

One thing blocks it: images, mount and unmount use the old image API (get_images / mount_image). Application 2.5.3 moved virtual media to the storage API, /storage/media, which MediaController covers since #70. On the 2.5.4 unit, nanokvm images printed nothing, while get_media() listed the shared partition. On current firmware the CLI shows an incomplete view of the media.

Could you drop images, mount and unmount from this PR and keep info, status, power and reset? That part is useful on its own and I'd merge it. Media can come back in a follow-up that uses get_media() / mount_media() on 2.5.3+ and the old calls below it.

The command runs on the blocking client: info, status, power press, on
and off, reset, images, mount and unmount. 'power on' and 'power off'
do nothing when the power LED already shows that state, and otherwise
wait for the LED. The password comes from NANOKVM_PASSWORD or a prompt,
never from the command line.
@antoniovazquezblanco

Copy link
Copy Markdown
Contributor Author

No worries about review speed please! This is and has been a great experience! Get to it if you want and whenever you want! :D

Yeah, not a bad idea to reduce scope, probably easier to review like this!

Thank you! :)

@chiconws
chiconws merged commit 3da989d into puddly:dev Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants